[Helm] Add support for ingressClassName #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Wagner <n.wagner@finatix.de>
|
|
|
Thank you @NiklasWagner! We'll make sure to review. |
david-yu
reviewed
Nov 9, 2021
| [ "${actual}" = "null" ] | ||
| } | ||
|
|
||
| @test "ui/Ingress: no ingressClassName by default" { |
There was a problem hiding this comment.
It looks like the tests are complaining about a duplicate test name? Should this be "ui/Ingress: set ingressClassName to nginx"
|
@NiklasWagner, I continued your work in this PR, making the changes we needed to merge it. We will be sure to merge it without squashing so you get contribution credit! Thank you so much for doing this work. I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niklas Wagner n.wagner@finatix.de
Changes proposed in this PR:
How I've tested this PR:
helm templatecomannd locally with ingressClassName enabled and without it.How I expect reviewers to test this PR:
ui.ingress.classNameand you should see the ingressClassName field within the Ingress object.Checklist: